Skip to content

CI: Xfails on Python 3.10 #41595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 51 commits into from
Jun 29, 2021
Merged

CI: Xfails on Python 3.10 #41595

merged 51 commits into from
Jun 29, 2021

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented May 20, 2021 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

The Python 3.10 CI is actually red, but the continue-on-error flag makes it so that the job is not failed. WIP because tests actually have to be fixed.
Added Xfails for some tests. Pretty much green except for #41935

@lithomas1 lithomas1 added Python 3.10 Compat pandas objects compatability with Numpy or Python functions labels May 20, 2021
@jreback
Copy link
Contributor

jreback commented May 21, 2021

right this was done on purpose so that we have time to fix the tests

so happy to merge this once all green otherwise

@lithomas1
Copy link
Member Author

@jreback I think we should xfail these instead of doing this for now, and look into fixing them. The current setup means that its hard to tell if something breaks more tests on Python 3.10 in addition to the ones currently failing.

@jreback
Copy link
Contributor

jreback commented May 21, 2021

@jreback I think we should xfail these instead of doing this for now, and look into fixing them. The current setup means that its hard to tell if something breaks more tests on Python 3.10 in addition to the ones currently failing.

sure happy to do that as well. I agree that's better.

jreback
jreback requested changes May 25, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ;
comment and ping when green

@pep8speaks
Copy link

pep8speaks commented May 25, 2021 •
edited
Loading

Hello @lithomas1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-28 15:35:29 UTC

@lithomas1
Copy link
Member Author

Still WIP becaue there's a ton of flaky tests and idk what's wrong with sparse tests.

@lithomas1 lithomas1 marked this pull request as ready for review May 31, 2021 23:28
@lithomas1 lithomas1 marked this pull request as draft May 31, 2021 23:32
@lithomas1 lithomas1 added the Testing pandas testing functions or related to the test suite label Jun 2, 2021
@lithomas1 lithomas1 closed this Jun 27, 2021
@lithomas1 lithomas1 reopened this Jun 27, 2021
@lithomas1 lithomas1 changed the title CI: Fail on Python 3.10 Pytest Failure CI: Xfails on Python 3.10 Jun 28, 2021
@lithomas1 lithomas1 requested a review from jreback June 28, 2021 16:26
@lithomas1 lithomas1 added this to the 1.3 milestone Jun 28, 2021
@jreback jreback merged commit de40a88 into pandas-dev:master Jun 29, 2021
@jreback
Copy link
Contributor

jreback commented Jun 29, 2021

thanks @lithomas1 very nice!

@meeseeksmachine meeseeksmachine mentioned this pull request Jun 29, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jun 29, 2021
@lithomas1 @meeseeksmachine
Backport PR pandas-dev#41595: CI: Xfails on Python 3.10
fdf34b2
@jreback
Copy link
Contributor

jreback commented Jun 29, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 29, 2021

Something went wrong ... Please have a look at my logs.

simonjayhawkins pushed a commit that referenced this pull request Jun 29, 2021
@meeseeksmachine @lithomas1
Backport PR #41595: CI: Xfails on Python 3.10 (#42297)
0ef6073 
Co-authored-by: Thomas Li <[email protected]>
@lithomas1 lithomas1 deleted the patch-1 branch June 29, 2021 13:55
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@lithomas1 @JulianWgs
CI: Xfails on Python 3.10 (pandas-dev#41595)
39b59c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Python 3.10 Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@lithomas1 @jreback @pep8speaks